Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CelebA dataset loading, remove eval() call #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philippeitis
Copy link
Contributor

@philippeitis philippeitis commented Feb 10, 2021

It seems like the CelebA datasets don't filter out non-matching sizes, which causes problems when trying to run the notebooks provided in /reproducability - the default behaviour seems to download both (3, 218, 178) and (3, 32, 32) images into the celeba32 folder, causing bugs when trying to run the models (for instance, running CNP.ipynb fails when running everything from scratch). Adding a transform.Resize() to the __init__() method for CelebA64 fixes this - alternatively, having a set up script to filter images into separate directories could also be useful.

Additionally, the eval() call in imgs.py seems like an easy source of bugs and confusion - I think it's better to split the datasets into a separate datasets.py file and provide the dict with direct class references (and avoid eval()) in imgs.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant