Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix contentinset bug #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix contentinset bug #99

wants to merge 1 commit into from

Conversation

dylanNew
Copy link

No description provided.

@rnkyr rnkyr changed the base branch from master to feature/swift-4-2 October 16, 2018 12:30
@rnkyr
Copy link
Contributor

rnkyr commented Oct 16, 2018

hey @dylanNew!
please leave some description what exactly your PR fixes
these changes looks important and could impact existing users

@rnkyr rnkyr changed the base branch from feature/swift-4-2 to master October 16, 2018 13:08
@hyouuu
Copy link

hyouuu commented Dec 11, 2018

@rnkyr I think that's because the following lines check offset against 0, but we could be setting the offset to start with an inset, so the result won't be right.
A side issue is that the .initial state is never called, and when I pull half way then release there's no call back - how do you deal with cancelled state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dylanNew @rnkyr @hyouuu @chaoxin-specs