-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python38 and refactor tests to use pytest-asyncio #18
Conversation
I love where this is going! Thanks for addressing the tests @FlorianLudwig! |
@FlorianLudwig do we want to squash commits? I could squash all of mine into a single |
tl;drpragmatic, i would just leave it as is. squashing commitsIt is on my TODO list to write my thoughts about squashing - a complicated topic indeed. So let me have a take on it :) Just to make a simple question a discussion about principles. The git history is part of the work of a developer and not a backup. It should tell a story, each commit is one scene. Jumping to much between them and you lose your reader (that might be yourself in a few month, trying to understand why the code ended up the way it did or some psychopath). Some rules of thumb:
|
…s0, race conditions on detached sessions, eliminated set_exception on client disconnect tasks, a few debug log message isEnabledFor wrappers." This reverts commit 1f5efd3.
rebased version of njouanin/hbmqtt#226
depends on #17