Refactor saving files

src/base/repositories/AbstractFileRepository.ts

@@ -1,25 +1,48 @@
 const fs = require('fs');
+const path = require('path');
+
+const APP_FOLDER = 'YadroTimeTracker';
+const PROFILE_FOLDER = 'profile1';
 
 export default abstract class AbstractFileRepository<T = any> {
-  folder: string = 'profile1';
+  folderWithProfile: string = 'profile1';
   fileName: string = 'defaultFileName.json';
 
-  get path() {
-    return `${this.folder}/${this.fileName}`;
+  private static get appDataFolder() {
+    return process.env.APPDATA || '';
+  }
+
+  private static get profileFolder() {
+    return path.join(
+      AbstractFileRepository.appDataFolder,
+      APP_FOLDER,
+      PROFILE_FOLDER
+    );
+  }
+
+  private get filePath() {
+    return path.join(AbstractFileRepository.profileFolder, this.fileName);
   }
 
   public restore(defaultValue: T): T {
-    if (fs.existsSync(this.path)) {
-      const data = fs.readFileSync(this.path);
+    if (fs.existsSync(this.filePath)) {
+      const data = fs.readFileSync(this.filePath);
       return JSON.parse(data);
     }
     return defaultValue;
   }
 
   public save(data: T) {
-    if (!fs.existsSync(this.folder)) {
-      fs.mkdirSync(this.folder);
+    [
+      path.join(AbstractFileRepository.appDataFolder, APP_FOLDER),
+      AbstractFileRepository.profileFolder,
+    ].forEach((p) => AbstractFileRepository.createFolderIfNotExists(p));
+    fs.writeFileSync(this.filePath, JSON.stringify(data), 'utf-8');
+  }
+
+  private static createFolderIfNotExists(path: string) {
+    if (!fs.existsSync(path)) {
+      fs.mkdirSync(path);
     }
-    fs.writeFileSync(this.path, JSON.stringify(data), 'utf-8');
   }
 }

src/models/ProjectModel.ts

@@ -18,7 +18,7 @@ export default class ProjectModel extends AbstractModel
 
   constructor(props: IJsonProjectItem) {
     super();
-    this.load(props);
+    this.load(props); // TODO вынести итератор
     this.children = props.children?.map((json) => new ProjectModel(json)) || [];
   }
 }