ImGui ent props #346
Merged
ImGui ent props #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncraftedName
force-pushed
the
imgui-ent-props
branch
from
a030621 to
8a5d9dc
Compare
lipsanen
reviewed
Sep 17, 2024
UncraftedName
force-pushed
the
imgui-ent-props
branch
from
8a5d9dc to
42d212f
Compare
|
tyvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be merged after #345.
Changes:
spt_hud_ent_infoto the hud tabutils::ClientEntity()to return null for large indices because the game doesn't do that check for us and this can trigger a crash otherwise (the game does check forindex<0though)utils::FillInfoArray()to make it slightly more resilient to weird user inputI've tested this with a bunch of weird user input - to the best of my knowledge it syncs up with the
utils::FillInfoArray()logic and gracefully handles weird edge cases. When the user interacts with the GUI, it sort of "normalizes" the cvar value to something slightly more sensible.2024-09-17.04-42-28.mp4