Add Deny Reason to Application Route

[Neshura87]

WIP Pull Request, no idea how long this will take.

Current Plan is to:

• Merge the Tick and Cross Buttons into a single "Deny" button (Edit: Once the cross has been clicked to deny the request), maybe even with an Animation
• Add a Textbox for a Deny reason to the left of the new "Deny" button
• Display deny reasons next to the "Denied by XY" Text in the Style: "Denied by XY: 'Deny Reason'"

@Xyphyn before I start working on it do the planned changes sound acceptable?

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @Xyphyn on Vercel.

@Xyphyn first needs to authorize it.

[Xyphyn]

I'd prefer if it just opened a modal instead, so it works on all screen sizes. The deny reason can open on hover with a PopOver. If you'd like, I can work on it myself today.

[Neshura87]

Modal works for me, I can work on it myself, been looking for stuff to do anyway

[Neshura87]

I disagree with the PopOver idea though, the application text is currently plainly visible without having to press another button and in my opinion the same should be the case for the deny reason.

Would it not be possible to display the deny reason in it's own row? Like So

Application:
xy application reason

Deny Reason:
deny reason goes here

Denied by Admin

It would make the application card longer but should still work on all screen sizes while making the info viewable at a glance

[Xyphyn]

Looks good, but I would prefer if it looked like this:

Denied by admin name

<deny reason, if exists>

[Neshura87]

Great, will get to it soon then, just finished work

[Neshura87]

Not 100% sure about the await new Promise(res => setTimeout(res, 1000)) workaround but it's a 1s timer so it shouldn't affect performance in any way and is the recommended way I've seen for a delay in TypeScript

[Neshura87]

Aside from code style I should be done now, haven't found any bugs in my quick round of testing

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
photon	✅ Ready (Inspect)	Visit Preview	Nov 29, 2023 3:34pm

[Xyphyn]

There was a build error, (typically these don't affect anything in yarn dev) try using yarn build to see what it is

[Neshura87]

Built current main branch and my own branch and both have the same build output aside from timing and hashes, I can take a closer look tomorrow but from my limited testing it seems like a random fail in Vercel (or some Vercel quirk I'm unfamiliar with)

[Xyphyn]

In a function as a parameter in svelte, there's a missing }.

[Neshura87]

Can't figure out where rn, will check tomorrow

[Neshura87]

ran a vercel deploy on my own account with default settings and that one fails because it can't find the svelte vercel adapter, can you share ypur vercel deploy settings so I can debug this?

[Neshura87]

vercel deploy works for me without errors when I add adapter-vercel as a dev dependency

[Neshura87]

Did more testing and I cannot replicate the build error.
Here are my findings:
Local Preview: ✔️
Local Build: ✔️
Docker Build: ✔️
Vercel Deploy from my Fork with default Settings: ❌ -> cannot install @sveltejs/adapter-vercel 2.4.3
Vercel Deploy from my Fork with default Settings and "@sveltejs/adapter-vercel": "^2.4.3" added as devDependency: ✔️
This Build: ❌ -> according to what you told me with a Svelte Build Error

The only way I can see the above making sense is if the Vercel deploy in this PR built an old version of my code that had errors

[Xyphyn]

Vercel is deploying the wrong commit aaaa

[Xyphyn]

Looks good, thanks a lot for your contribution!