fix(src): tweak error handling debug verboseness in certain edge cases

Xunnamius · Jul 12, 2024 · 96ce293 · 96ce293
1 parent dcb4d3c
commit 96ce293
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 18 deletions.
diff --git a/src/discover.ts b/src/discover.ts
@@ -363,7 +363,7 @@ export async function discoverCommands(
           ) {
             debug_.warn(
               'a recoverable failure occurred while attempting to load configuration: %O',
-              `${error}`
+              error
             );
           } else {
             throw error;
@@ -514,7 +514,7 @@ export async function discoverCommands(
       } catch (error) {
         debug_.error(
           'an irrecoverable failure occurred while loading configuration: %O',
-          `${error}`
+          error
         );
 
         throw error;

diff --git a/src/util.ts b/src/util.ts
@@ -320,7 +320,6 @@ export async function runProgram<
   let configurationHooks: ConfigurationHooks | undefined = undefined;
   let preExecutionContext: PreExecutionContext | undefined = undefined;
   let successfullyHandledErrorViaConfigurationHook = false;
-  let alreadyDidErrorHandling = false;
 
   try {
     if (typeof args[1] === 'string' || Array.isArray(args[1])) {
@@ -394,21 +393,6 @@ export async function runProgram<
     debug_('runProgram invocation succeeded');
     return parsedArgv;
   } catch (error) {
-    if (alreadyDidErrorHandling) {
-      debug_.warn(
-        `discarding exception from ${
-          preExecutionContext ? '::execute' : '::configureProgram'
-        } because error handling already happened: %O`,
-        error
-      );
-
-      debug_.message(
-        'note that seeing the above message may be a code smell. Check the documentation on CliError::dangerouslyFatal for more information'
-      );
-    }
-
-    alreadyDidErrorHandling = true;
-
     debug_.error(
       `handling irrecoverable exception from ${
         preExecutionContext ? '::execute' : '::configureProgram'