Add JSX support. #12
Open
Add JSX support. #12
+382
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeresig
commented
Jul 15, 2024
| import { NodePath, PluginObj, PluginPass } from '@babel/core'; | ||
| import debugFactory from 'debug'; | ||
| import * as util from '@babel/types'; | ||
| import template from '@babel/template'; | ||
|
|
||
| const pkgName = 'babel-plugin-explicit-exports-references'; |
There was a problem hiding this comment.
I had to change this to get the tsconfig.build.json to work (since the root is now src/).
|
Thank you for this! This is a super old project that I use often but have neglected to bring up to date with my lastest infra. I'll take a look |
|
Update: waiting until https://github.com/Xunnamius/xscripts is finished before merging this in |
|
hi @Xunnamius is there any update to this? I am also getting the same error, hoping it solves that problem. |
|
@2K-Es I'm focusing on unifying my dev-integrate-release loop across my projects, but perhaps I'll cut an ad hoc release for this package containing John's fixes first. UPDATE: Will handle this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in JSX support to the explicit-exports-references babel plugin. When attempting to replace a JSXMemberExpression with a plain MemberExpression there was an error generated by Babel. This fixes that by explicitly creating a JSXMemberExpression when replacing a JSXIdentifier or the name of the openingElement of a JSXElement.
In the process I noticed that there was no ability to generate a production build, there is no Webpack config. So I changed the logic so that the build is generated by TypeScript now, no Webpack needed.
Test Plan:
The tests pass! This required updating a bunch of infrastructure to support React.