Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer Operation erase using llvm::SmallSet #750

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Safer Operation erase using llvm::SmallSet #750

merged 1 commit into from
Oct 23, 2024

Conversation

erwei-xilinx
Copy link
Collaborator

No description provided.

@erwei-xilinx erwei-xilinx changed the title Safer Operation erase using llvm::SmallSet Safer Operation erase using llvm::SmallSet Oct 23, 2024
@erwei-xilinx erwei-xilinx enabled auto-merge (squash) October 23, 2024 07:32
@erwei-xilinx erwei-xilinx merged commit 9e333ad into Xilinx:main Oct 23, 2024
11 checks passed
@erwei-xilinx erwei-xilinx deleted the llvm_smallset_erased branch October 23, 2024 07:32
@fifield
Copy link
Collaborator

fifield commented Oct 23, 2024

Why can't this op be handled by a conversion pattern like the other ops?

@erwei-xilinx
Copy link
Collaborator Author

Why can't this op be handled by a conversion pattern like the other ops?

This PR changes the way that Operations targetted for deletion were collected in passes, where previously they were buffered in a SmallVector before being deleted, posing the risk of deleting the same op multiple times. This PR changes to buffer them using SmallSet instead.

Hmm this PR isn't targetting any specific op conversion or transformation, so which op are we referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifield fifield Awaiting requested review from fifield fifield is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwei-xilinx @fifield