AIRCopyToDma: Compose a chain of memref ops to src/dst memrefs, as canonicalizer #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…air.channel.put/get and air.dma_memcpy_nd
fifield
reviewed
Oct 23, 2024
Comment on lines
1482
to
1484
| for (unsigned i = 0; i < op->getNumResults(); i++) { | ||
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | ||
| } |
There was a problem hiding this comment.
Use the rewriter instead of direct IR modification:
Suggested change
| for (unsigned i = 0; i < op->getNumResults(); i++) { | |
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | |
| } | |
| rewriter.replaceOp(op, newOp); |
There was a problem hiding this comment.
Great point. Updated to use replaceOpWithNewOp method.
Comment on lines
1347
to
1349
| for (unsigned i = 0; i < op->getNumResults(); i++) { | ||
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | ||
| } |
There was a problem hiding this comment.
Use the rewriter instead of direct IR modification:
Suggested change
| for (unsigned i = 0; i < op->getNumResults(); i++) { | |
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | |
| } | |
| rewriter.replaceOp(op, newOp); |
Comment on lines
1434
to
1436
| for (unsigned i = 0; i < op->getNumResults(); i++) { | ||
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | ||
| } |
There was a problem hiding this comment.
Use the rewriter instead of direct IR modification:
Suggested change
| for (unsigned i = 0; i < op->getNumResults(); i++) { | |
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | |
| } | |
| rewriter.replaceOp(op, newOp); |
Comment on lines
1385
to
1387
| for (unsigned i = 0; i < op->getNumResults(); i++) { | ||
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | ||
| } |
There was a problem hiding this comment.
Use the rewriter instead of direct IR modification:
Suggested change
| for (unsigned i = 0; i < op->getNumResults(); i++) { | |
| op->getResult(i).replaceAllUsesWith(newOp->getResult(i)); | |
| } | |
| rewriter.replaceOp(op, newOp); |
Comment on lines
-1618
to
-1623
| for (auto dmaOp : dma_ops) { | ||
| if (failed(condenseMemrefDataReorderingToAIRDma( | ||
| std::get<0>(dmaOp), std::get<1>(dmaOp), std::get<2>(dmaOp)))) { | ||
| return signalPassFailure(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Run the moved code here?
Suggested change
| for (auto dmaOp : dma_ops) { | |
| if (failed(condenseMemrefDataReorderingToAIRDma( | |
| std::get<0>(dmaOp), std::get<1>(dmaOp), std::get<2>(dmaOp)))) { | |
| return signalPassFailure(); | |
| } | |
| } | |
| RewritePatternSet pattern(ctx); | |
| DmaMemcpyNdOp::getCanonicalizationPatterns(pattern, ctx); | |
| (void)applyPatternsAndFoldGreedily(module, std::move(pattern)); |
There was a problem hiding this comment.
Great point. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.