Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR-1167063 Fix hwqueue_handle::wait_command() API comment #7609

Merged
merged 2 commits into from
Jul 24, 2023
Merged

CR-1167063 Fix hwqueue_handle::wait_command() API comment #7609

merged 2 commits into from
Jul 24, 2023

Commits on Jun 30, 2023

  1. CR-1167063 Fix hwqueue_handle::wait_command() API comment 

    Remove comment about cmd nullptr waiting for any command to complete.

Throw if nullptr is passed.  This means that OpenCL is not supported
with platforms that implement hwqueue. If OpenCL support is needed,
the command monitor needs to track order of submitted commands and
wait on first submitted command before checking status of all running
commands.

Signed-off-by: Soren Soe <[email protected]>
    @stsoe
    stsoe committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    12c1a0e View commit details
    Browse the repository at this point in the history

  2. fix windows build error 

    Signed-off-by: Soren Soe <[email protected]>
    @stsoe
    stsoe committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    c46b7a9 View commit details
    Browse the repository at this point in the history