-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for mem_banks for --add-pskernel #7606
Conversation
Signed-off-by: xilinxfei <[email protected]>
Can one of the admins verify this patch? |
Currently, the output looks like the following
|
retest this please |
1 similar comment
retest this please |
Build Passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes are being requested.
src/runtime_src/tools/xclbinutil/unittests/PSKernel/PSKernel.py
Outdated
Show resolved
Hide resolved
Signed-off-by: xilinxfei <[email protected]>
retest this please |
retest this please. |
Build failed :( |
Signed-off-by: xilinxfei <[email protected]>
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making these changes.
retest this please |
retest this please. |
Build Passed! |
Problem solved by the commit
Add support for mem_banks for --add-pskernel
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
N/A
How problem was solved, alternative solutions (if any) and why they were rejected
N/A
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Manual and unit test
Documentation impact (if any)
None