Fix bug in CMake function #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore missing directory in xrt_add_subdirectory. xrt_add_subdirectory is used to conditionally exclude directories from CMake generation. If the directory was explicitly removed prior to CMake generation, the function would error. Add test that directory exists.
|
Build Passed! |
abalasa
pushed a commit
to abalasa/XRT-1
that referenced
this pull request
Jun 30, 2023
Ignore missing directory in xrt_add_subdirectory. xrt_add_subdirectory is used to conditionally exclude directories from CMake generation. If the directory was explicitly removed prior to CMake generation, the function would error. Add test that directory exists.
abalasa
added a commit
that referenced
this pull request
Jun 30, 2023
Fix bug in CMake function (#7604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Ignore missing directory in xrt_add_subdirectory.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
xrt_add_subdirectory is used to conditionally exclude directories from CMake generation. If the directory was explicitly removed prior to CMake generation, the function would error.
How problem was solved, alternative solutions (if any) and why they were rejected
Add test that directory exists.