-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XRT OS Support for RHEl 8.8 and 9.2 #7603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manoj Takasi <[email protected]>
Can one of the admins verify this patch? |
maxzhen
approved these changes
Jun 26, 2023
add to whitelist |
ok to test |
chvamshi-xilinx
approved these changes
Jun 26, 2023
#if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(9, 1) | ||
#define RHEL_9_1_GE | ||
#endif | ||
#if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(9, 0) | ||
#define RHEL_9_0_GE | ||
#endif | ||
#if RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(8, 7) | ||
#if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(8, 7) | ||
#define RHEL_8_7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to rename this to RHEL_8_7_GE
retest this please. |
Build failed :( |
retest this please. |
retest this please |
1 similar comment
retest this please |
Build failed :( |
retest this please. |
Build failed :( |
retest this please. |
Signed-off-by: Manoj Takasi <[email protected]>
Build Passed! |
michaellass
pushed a commit
to pc2/XRT
that referenced
this pull request
Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> * Made few changes to provide OS support for RHEL 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> (cherry picked from commit 6eff2fc)
michaellass
pushed a commit
to pc2/XRT
that referenced
this pull request
Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> * Made few changes to provide OS support for RHEL 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> (cherry picked from commit 6eff2fc)
michaellass
pushed a commit
to pc2/XRT
that referenced
this pull request
Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> * Made few changes to provide OS support for RHEL 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> (cherry picked from commit 6eff2fc)
michaellass
pushed a commit
to pc2/XRT
that referenced
this pull request
Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> * Made few changes to provide OS support for RHEL 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> (cherry picked from commit 6eff2fc)
michaellass
pushed a commit
to pc2/XRT
that referenced
this pull request
Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> * Made few changes to provide OS support for RHEL 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> (cherry picked from commit 6eff2fc)
michaellass
pushed a commit
to pc2/XRT
that referenced
this pull request
Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> * Made few changes to provide OS support for RHEL 8.8 and 9.2 Signed-off-by: Manoj Takasi <[email protected]> --------- Signed-off-by: Manoj Takasi <[email protected]> (cherry picked from commit 6eff2fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Providing XRT support for RHEl 8.8 and 9.2.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
By adding appropiate checks in the xocl_drv.h file and ulite.c file
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested xrt package creation and installation on RHEL 8.8 and RHEL 9.2 VM
Documentation impact (if any)
NA