corrected review comments

XeroAPI · Sep 30, 2024 · d2bc4eb · d2bc4eb
1 parent f3bfe77
commit d2bc4eb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -1,5 +1,6 @@
 name: Publish
 on:
+    push:
     release:
         types: [published]
 
@@ -20,26 +21,16 @@ jobs:
                 distribution: 'temurin'
                 java-version: '11'
                 cache: maven
+                server-id: ossrh
+                server-username: ${{ secrets.MAVEN_USERNAME }}
+                server-password: ${{ secrets.MAVEN_TOKEN }}
 
             - name: Import GPG Key
               run: |
                 echo "${{ secrets.GPG_PRIVATE_KEY }}" | gpg --batch --import
               env: 
                 GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY}}
 
-            - name: Configure Maven settings
-              run: |
-                mkdir -p ~/.m2
-                echo "<settings>
-                        <servers>
-                            <server>
-                              <id>ossrh</id>
-                              <username>${{ secrets.MAVEN_USERNAME }}</username>
-                              <password>${{ secrets.MAVEN_TOKEN }}</password>
-                            </server>
-                          </servers>
-                        </settings>" > ~/.m2/settings.xml
-
             - name: Publish to Maven
               run: |
                 export GPG_TTY=$(tty)

diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
     <artifactId>xero-java</artifactId>
     <packaging>jar</packaging>
     <name>xero-java</name>
-    <version>8.3.0</version>
+    <version>8.3.0-alpha.3</version>
     <url>https://github.com/XeroAPI/Xero-Java</url>
     <description>This is the official Java SDK for Xero API</description>
     <licenses>