Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add command to install docker in readme" #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert "add command to install docker in readme" #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
348a244
Revert "add command to install docker in readme"
codecakes Nov 14, 2020
079c11f
Merge branch 'master' into revert-132-bug/docker-setup-mac
vasynizami Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ In general follow this [Javascript Styleguide](https://google.github.io/stylegui
docker-compose -f "docker-compose.yml" up -d --build
```

If this command doesn't work, run

```bash
PORT=9119 docker-compose up
```

Typescript to compile project.
Babel does the transpiling from target to es5 browser compatible code, tsc does the type-checking.
[See this](https://babeljs.io/blog/2018/08/27/7.0.0) for more info on how to run babel projects using tsc.
Expand Down
1 change: 0 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ services:
- "/app/node_modules"
environment:
- PORT=9119
- CHOKIDAR_USEPOLLING="true"