Feature/frontend/enhancement new sort #131
Conversation
…o feature/frontend/enhancement-sorting_by_distance
DeepCode's analysis on #db1b19 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
@Jasonwei1106 pls make sure to tag @ksr89 as reviewer in all PRs |
src/components/Header.jsx
Outdated
| @@ -11,5 +11,4 @@ const Header = () => { | |||
| ); | |||
| }; | |||
|
|
|||
| export default Header; | |||
|
|
|||
| export default Header; | |||
There was a problem hiding this comment.
missing end of file empty line
src/containers/Search.jsx
Outdated
| inputArr.forEach(element => { | ||
| element.dist = callback(element.geometry.location,this.state.lat,this.state.lng,"K"); | ||
| }); | ||
| console.log(inputArr); |
There was a problem hiding this comment.
pls remove this from production code
| @@ -137,32 +147,35 @@ class Search extends Component { | |||
| * @param {string} unit - required unit of distance in kilometers('K') or nautical miles('N'). | |||
There was a problem hiding this comment.
pls check if jsdoc annotations for each parameter are provided
| @@ -228,7 +241,8 @@ class Search extends Component { | |||
| } = this.state; | |||
| const result_list = | |||
| results && results.length !== 0 | |||
| ? results.map( | |||
| ? results.sort((a,b)=>a.dist-b.dist) | |||
There was a problem hiding this comment.
maybe use absolute value;
There was a problem hiding this comment.
it is sorted based on if it is a negative or positive number, if I use abs it will always put 'a' at the front
There was a problem hiding this comment.
the way you do sorting here is to find relevant distances from user location, find a diff/ in distance from user location. it can never be < zero.
|
After I merge from master App.css has stylelint error. |
| @@ -228,8 +247,12 @@ class Search extends Component { | |||
| } = this.state; | |||
| const result_list = | |||
| results && results.length !== 0 | |||
| ? results.map( | |||
| ({ facility_type, formatted_address, geometry: { location } }, index) => { | |||
| ? results.sort((a,b)=>a.dist-b.dist) | |||
There was a problem hiding this comment.
@Jasonwei1106 Don't use JavaScript sort inside the render, Use it inside distancesort function.
This change is