Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
I think I fixed the compile errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@MatthewL246
MatthewL246 committed Sep 12, 2023
1 parent dd156fa commit 38989c1
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .idea/kotlinc.xml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion .idea/misc.xml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions FtcRobotController/build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ android {
compileSdkVersion 33

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
}
namespace = 'com.qualcomm.ftcrobotcontroller'

Expand Down
4 changes: 2 additions & 2 deletions PathVisualizer/build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ test {
useJUnitPlatform()
}
java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}
4 changes: 2 additions & 2 deletions build.common.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
}

packagingOptions {
Expand Down

3 comments on commit 38989c1

@MatthewL246
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaell4438 I fixed the build! You might need to download the Temurin OpenJDK 11 in your IntelliJ JDK manager to get it to work on your computer. This should be good though because now GitHub Actions and local builds will use the same JDK.

@tom-ricci
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i shouldn't be commenting considering. im not on the team anymore. but pls check to make sure going to 11 is game legal, i chose 1.8 specifically and i think it had to do with legality? or it could've been library compatibility or something. not sure

if its legal and 11 works by all means switch to it though, the newer the java build the better

@tom-ricci
Copy link

@tom-ricci tom-ricci commented on 38989c1 Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH I REMEMBER IT WAS BECAUSE OF MIN COMPILE VERSION

gradle was set to a target version of android api level 25 or 26 at one point, and sometimes level 25 didn't play nicely with newer language features (compiled fine, but killed itself during runtime)

i did manage to get it targeting 33 eventually but i believe it still might be supporting 25 as the minimum api level. make sure the phones, ds, and hub support an api level which supports java 11 before using features from 11

worse case scenario u just have to set the ide language level at 1.8 but compile to 11. actually i believe my ide language level was 16 but it was compiling for 1.8, and it just worked somehow. maybe its fine idk

Please sign in to comment.