Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show count of browse (Issue 106) #117

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Conversation

sk8higher
Copy link
Contributor

@sk8higher sk8higher commented Oct 20, 2023

Fixed buttons render (before that page crashed if you're not logged in)

@XaoGao XaoGao self-requested a review October 20, 2023 13:16
@XaoGao XaoGao linked an issue Oct 20, 2023 that may be closed by this pull request
Copy link
Owner

@XaoGao XaoGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk8higher pls fix

@@ -1,11 +1,14 @@
.container.d-flex.flex-column.align-items-center
h1 = @vacancy.title
- if user_signed_in? && current_user.id == @vacancy.user_id
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk8higher I think will be better to create a new method, like

user.owner?(@vacancy) 

write test

@sk8higher
Copy link
Contributor Author

@XaoGao done

Copy link
Owner

@XaoGao XaoGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk8higher approve

@XaoGao XaoGao merged commit d5f2ff3 into XaoGao:develop Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show count of browse
2 participants