This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
dev/spatial-awareness-refactor #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
added
Breaking Change
Ready for review
...ore/Packages/com.xrtk.core/Providers/SpatialObservers/BaseMixedRealitySpatialMeshObserver.cs
Show resolved
Hide resolved
FejZa
reviewed
Aug 12, 2019
...re/Packages/com.xrtk.core/Interfaces/SpatialAwareness/IMixedRealitySpatialAwarenessSystem.cs
Outdated
Show resolved
Hide resolved
Merged
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Aug 16, 2019
* Moved mesh display options from the data provider profile to the system profile * updated profile inspectors * updated SDK checkout * updated sdk checkout * reverted checkout * Removed obsolete members per CR * Fixed submodule checkouts * updated sdk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Moved mesh display options from the data provider profile to the system profile for easier ability to track spatial mesh visibility.
Target of the change:
Is this enhancement for:
Breaking Changes:
IMixedRealitySpatialAwarenessSystem.SetMeshVisibilityobsoleteBaseMixedRealitySpatialMeshObserverProfile.MeshDisplayOptionobsoleteIMixedRealitySpatialAwarenessSystem.SpatialMeshVisibility