feat: export Balance type (#2374)

Closes #1823
XRPLF · Jul 10, 2023 · f07e2c7 · f07e2c7
1 parent 8243691
commit f07e2c7
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 20 deletions.
diff --git a/packages/xrpl/src/models/common/index.ts b/packages/xrpl/src/models/common/index.ts
@@ -17,6 +17,12 @@ export interface IssuedCurrencyAmount extends IssuedCurrency {
 
 export type Amount = IssuedCurrencyAmount | string
 
+export interface Balance {
+  currency: string
+  issuer?: string
+  value: string
+}
+
 export interface Signer {
   Signer: {
     Account: string

diff --git a/packages/xrpl/src/sugar/balances.ts b/packages/xrpl/src/sugar/balances.ts
@@ -1,6 +1,6 @@
 import flatMap from 'lodash/flatMap'
 
-import type { Client } from '..'
+import type { Balance, Client } from '..'
 import {
   AccountLinesRequest,
   AccountLinesTrustline,
@@ -9,12 +9,6 @@ import {
 } from '../models'
 import { dropsToXrp } from '../utils'
 
-interface Balance {
-  value: string
-  currency: string
-  issuer?: string
-}
-
 function formatBalances(trustlines: AccountLinesTrustline[]): Balance[] {
   return trustlines.map((trustline) => ({
     value: trustline.balance,

diff --git a/packages/xrpl/src/utils/getBalanceChanges.ts b/packages/xrpl/src/utils/getBalanceChanges.ts
@@ -2,17 +2,16 @@ import BigNumber from 'bignumber.js'
 import flatten from 'lodash/flatten'
 import groupBy from 'lodash/groupBy'
 
-import { Amount, IssuedCurrencyAmount } from '../models/common'
-import { TransactionMetadata, Node } from '../models/transactions/metadata'
+import {
+  Amount,
+  Balance,
+  IssuedCurrencyAmount,
+  TransactionMetadata,
+  Node,
+} from '../models'
 
 import { dropsToXrp } from './xrpConversion'
 
-interface Balance {
-  currency: string
-  issuer?: string
-  value: string
-}
-
 interface BalanceChange {
   account: string
   balance: Balance
@@ -164,11 +163,7 @@ export default function getBalanceChanges(
   metadata: TransactionMetadata,
 ): Array<{
   account: string
-  balances: Array<{
-    currency: string
-    issuer?: string
-    value: string
-  }>
+  balances: Balance[]
 }> {
   const quantities = normalizeNodes(metadata).map((node) => {
     if (node.LedgerEntryType === 'AccountRoot') {