Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.4.3 for PyPI release #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaintFresh
Copy link

Summary:

This pull request bumps the basicsr version to 1.4.3 to trigger a new release on PyPI. The new release will include an important fix for a torchvision import error that affects users relying on the latest PyPI version.

Issue:

The current version of basicsr (1.4.2) on PyPI is missing a fix for a ModuleNotFoundError related to importing the rgb_to_grayscale function from torchvision. This fix is already present in the main branch of the repository, but it hasn't been released to PyPI yet. (e.g. GFPGAN / ESRGAN in their colab notebook)

Solution:

By bumping the version number in the VERSION file, this pull request will trigger a new release on PyPI, making the fix available to all users who install basicsr through pip.

Testing:

I have confirmed that this fix works correctly in my local environment.

Summary:

This pull request bumps the `basicsr` version to 1.4.3 to trigger a new release on PyPI. The new release will include an important fix for a `torchvision` import error that affects users relying on the latest PyPI version.

Issue:

The current version of `basicsr` (1.4.2) on PyPI is missing a fix for a `ModuleNotFoundError` related to importing the `rgb_to_grayscale` function from `torchvision`.  This fix is already present in the main branch of the repository, but it hasn't been released to PyPI yet. (e.g. GFPGAN / ESRGAN in their colab notebook)

Solution:

By bumping the version number in the `VERSION` file, this pull request will trigger a new release on PyPI, making the fix available to all users who install `basicsr` through `pip`.

Testing:

I have confirmed that this fix works correctly in my local environment.
@DLesmes
Copy link

DLesmes commented Aug 13, 2024

Who can review those checks to approve this PR @SaintFresh ?? It would be very usefull to have this new version available 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants