Add commitment in solana getBlockHeight

src/balances/solana.ts

@@ -1,12 +1,14 @@
 import bs58 from 'bs58';
 import { Connection, PublicKey, Keypair } from "@solana/web3.js";
 import { Balance } from "./index";
+import { SOLANA_DEFAULT_COMMITMENT } from '../wallets/solana/solana.config';
 
 export async function pullSolanaNativeBalance(
   connection: Connection,
-  address: string
+  address: string,
 ): Promise<Balance> {
-  const lamports = await connection.getBalance(new PublicKey(address))
+  // solana web3.js doesn't support passing exact slot(block number) only minSlot, while fetching balance 
+  const lamports = await connection.getBalance(new PublicKey(address), SOLANA_DEFAULT_COMMITMENT)
 
   return {
     isNative: true,

src/balances/sui.ts

@@ -18,6 +18,8 @@ export interface SuiTransactionDetails {
 export async function pullSuiNativeBalance(conn: Connection, address: string): Promise<WalletBalance> {
   const provider = new JsonRpcProvider(conn);
 
+  // mysten SDK doesn't support passing checkpoint (block number) to getBalance
+  // https://github.com/MystenLabs/sui/issues/14137
   const rawBalance = await provider.getBalance({ owner: address });
 
   return {

src/wallets/solana/index.ts

@@ -6,7 +6,7 @@ import {
   RecentPrioritizationFees,
 } from "@solana/web3.js";
 import { decode } from "bs58";
-import { SOLANA, SOLANA_CHAIN_CONFIG, SolanaNetworks } from "./solana.config";
+import { SOLANA, SOLANA_CHAIN_CONFIG, SOLANA_DEFAULT_COMMITMENT, SolanaNetworks } from "./solana.config";
 import { PYTHNET, PYTHNET_CHAIN_CONFIG } from "./pythnet.config";
 import {
   BaseWalletOptions,
@@ -304,6 +304,6 @@ export class SolanaWalletToolbox extends WalletToolbox {
   }
 
   public async getBlockHeight(): Promise<number> {
-    return this.connection.getBlockHeight();
+    return this.connection.getBlockHeight(SOLANA_DEFAULT_COMMITMENT);
   }
 }

src/wallets/solana/solana.config.ts

@@ -4,6 +4,7 @@ const SOLANA_TESTNET = 'solana-devnet';
 const SOLANA_CURRENCY_SYMBOL = 'SOL';
 
 export const SOLANA = 'solana';
+export const SOLANA_DEFAULT_COMMITMENT = 'finalized';
 
 export const SOLANA_NETWORKS = {
   [SOLANA_MAINNET]: 1,