Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#724 - add new tokens #773

Merged
merged 3 commits into from
Mar 22, 2024
Merged

#724 - add new tokens #773

merged 3 commits into from
Mar 22, 2024

Conversation

sebastianscatularo
Copy link
Contributor

No description provided.

@sebastianscatularo sebastianscatularo marked this pull request as draft March 8, 2024 16:40
@sebastianscatularo sebastianscatularo marked this pull request as ready for review March 8, 2024 18:31
@xaler5
Copy link

xaler5 commented Mar 22, 2024

Hey @sebastianscatularo is there a way we can add our modifications to BKN in this PR ? I tried to follow the legacy instructions but it produces lot of link changes the same as this PR (from legacy repo to this current repo). We would like to modify our BKN token in the token_data.py file to the following

    "BKN": {
      "symbol": "BKN",
      "name": "Brickken (Portal)",
      "sourceAddress": "0x0A638F07ACc6969abF392bB009f216D22aDEa36d",
      "coingeckoId": "brickken",
      "markets": {
        "eth": ["uniswap"]
      },
      "logo": "https://etherscan.io/token/images/brickken_32.png",
      "destinations": {
        "bsc": {
          "address": "0x0e28bC9B03971E95acF9ae1326E51ecF9C55B498",
          "decimals": 18
        },
        "avax": {
          "address": "0xd44E4Dc8bdF7C1c62CfDBb182022097BA42Ac6bC",
          "decimals": 18
        }
      },
      "sourceDecimals": 18
    },

Currently only BSC is showed but we wrapped the token also on Avalanche.

When I run npm run gen to update the by_dest.csv / by_source.csv markets.json and so on all links changes because of the change in the repository.

Moreover from the advanced tools section of the bridge, it's impossible to find BKN if you search for BKN and the only way is to use the address directly, but then it shows with no logo. Is there a way we can fix logo and search through symbol across Ethereum / BSC / Avalanche which is the chains in which we are ?

@sebastianscatularo
Copy link
Contributor Author

@xaler5 to show up on portal bridge (advanced-tools) the token needs to have liquidity markets registered, that's possible why you are not seeing it there.

cc: @mliu-xlabs to be aware of it

@sebastianscatularo sebastianscatularo merged commit 41fea94 into main Mar 22, 2024
21 checks passed
@sebastianscatularo sebastianscatularo deleted the feat/add-new-tokens branch August 30, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants