Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer - changes and fixes #1238

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Footer - changes and fixes #1238

merged 3 commits into from
Jan 20, 2025

Conversation

giulianoconti
Copy link
Contributor

@giulianoconti giulianoconti commented Jan 16, 2025 •
edited by jira bot
Loading

POR-184

before/after

before1 after1
before2 after2

yuli-ferna
yuli-ferna reviewed Jan 20, 2025
View reviewed changes
apps/connect-v1/src/components/atoms/BuiltBy.tsx
<Link href="https://xlabs.xyz/" target="_blank">
<svg
fill="none"
height={logoWidth * 1.05263157895}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To always maintain the same original aspect ratio.
I can put width and height instead of just width if you prefer

@yuli-ferna yuli-ferna merged commit 736171b into main Jan 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuli-ferna yuli-ferna yuli-ferna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulianoconti @yuli-ferna