-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor interface #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonergodic
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably pair and clean up the Typescript parts together.
scnale
force-pushed
the
evm/definitive-interface
branch
from
October 1, 2024 16:58
905a771
to
4f9ae53
Compare
scnale
reviewed
Oct 1, 2024
scnale
force-pushed
the
evm/definitive-interface
branch
from
October 4, 2024 02:13
a734ff0
to
364348b
Compare
mat1asm
reviewed
Oct 4, 2024
scnale
force-pushed
the
evm/definitive-interface
branch
2 times, most recently
from
October 5, 2024 13:48
454a6b5
to
1195927
Compare
This is useful for the SDK and applications that want to transfer tokens.
In this way, transfers will include an approve instruction when necessary.
- sdk/solana and sdk/common were missing clean scripts which messed up builds in an unpredictable manner. - The contract and typescript builds were separated in the solana package because the global "build all" script was building its typescript tests before letting the solana sdk build.
scnale
force-pushed
the
evm/definitive-interface
branch
from
October 8, 2024 01:52
a7255ed
to
3b12a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.