Evm/approve max instruction #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scnale
force-pushed
the
evm/approve-max-instruction
branch
from
499c15d to
c975755
Compare
This is useful for the SDK and applications that want to transfer tokens.
In this way, transfers will include an approve instruction when necessary.
Now both L1 and L2 EVM chains are quoted in the same way.
If we don't round up, the quoted relay fee may be insufficient to cover the whole transfer.
scnale
force-pushed
the
evm/approve-max-instruction
branch
from
e4a21ad to
eed2391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually includes a few more changes:
relayFeefor fees that had a sub Mwei remainder.