Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

641: Allow whitespace on either side of main header delimiter #718

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

lindsay-stevens
Copy link
Contributor

Closes #641

Why is this the best possible solution? Were any other approaches considered?

A user might put white space on either side of the double colon delimiter, so it's stripped off the tokens after splitting. Trailing or leading white space isn't needed either so it's stripped off both ends of the tokens.

What are the regression risks?

Low risk, it should just fix the problem in #641. I updated the code branch for single colons, because although that usage has been deprecated since what seems like 2012, it's different question to #641 (e.g. should code for the single colon case be removed? raise an error instead? or a warning? etc).

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyxform tests and ruff check pyxform tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

@lindsay-stevens lindsay-stevens changed the title 641: Allow whitespace on either side of translation delimiter in header 641: Allow whitespace on either side of main header delimiter Sep 4, 2024
@lognaturel lognaturel merged commit 66283b6 into XLSForm:master Sep 4, 2024
10 checks passed
@lindsay-stevens lindsay-stevens deleted the pyxform-641 branch September 5, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim spaces after :: in language columns
2 participants