Add 'Other' label text for all languages defined by form #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
commented
Jan 16, 2024
| ], | ||
| ) | ||
|
|
||
| # region or_other |
There was a problem hiding this comment.
We haven't used regions yet. I find it helpful for navigation but don't feel strongly about it if we'd rather not introduce a new pattern.
lognaturel
force-pushed
the
or_other
branch
2 times, most recently
from
d6f954b
to
f8a4ec1
Compare
lognaturel
commented
Jan 17, 2024
|
|
||
| if isinstance(choice_list[0][const.LABEL], Dict): | ||
| # Get all langs defined across all existing choices in this list and give them all a label of "Other" | ||
| langs = set().union( |
There was a problem hiding this comment.
I think this is the only way to detect a multi-language choice list at this point in the code, right?
This looks particularly tricky to understand with the black formatting, I think. It may not be hugely performant but I don't think that matters in this context.
4 tasks
|
Replaced by #687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #683
Why is this the best possible solution? Were any other approaches considered?
It leads to all languages having a choice label of "Other" which is more similar to the behavior before pyxform 2 and will help with migration. A couple of implementation notes/questions are highlighted inline.
I also snuck in removing an error in case a select has both a choice filter and
or_other. Now all selects are built on secondary instances so the choice filter case is not special.What are the regression risks?
It's limited to or_other. I can imagine new issues around that behavior.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
testsnosetestsand verified all tests passblack pyxform teststo format code