Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WFSim connection #268

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Remove WFSim connection #268

merged 5 commits into from
Oct 16, 2024

Conversation

HenningSE
Copy link
Collaborator

What does the code in this PR do / what does it improve?

Solve #219

@HenningSE HenningSE linked an issue Oct 8, 2024 that may be closed by this pull request
Remove WFSim connection plugin? #219
Closed
@HenningSE
Copy link
Collaborator Author

Waiting for #267 to see if the tests work.

@coveralls
Copy link

coveralls commented Oct 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11363870643

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 79.936%
Files with Coverage Reduction New Missed Lines %
fuse/common.py 4 53.66%
Totals Coverage Status
Change from base Build 11334779769: -0.3%
Covered Lines: 2506
Relevant Lines: 3135
💛 - Coveralls

@HenningSE HenningSE marked this pull request as ready for review October 8, 2024 08:44
@HenningSE HenningSE requested a review from ramirezdiego October 8, 2024 08:44
ramirezdiego
ramirezdiego approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and rest in peace, WFSim 🌹

@ramirezdiego ramirezdiego merged commit fd40b75 into main Oct 16, 2024
3 of 4 checks passed
@ramirezdiego ramirezdiego deleted the remove_wfsim_connection_plugin branch October 16, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramirezdiego ramirezdiego ramirezdiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove WFSim connection plugin?
3 participants
@HenningSE @coveralls @ramirezdiego