Merge pull request microsoft#227245 from microsoft/tyriar/226868

Hide command guide if it's disable while showing
XAuthSystems · Aug 30, 2024 · ab4c5e0 · ab4c5e0
2 parents adb25cf + ac497db
commit ab4c5e0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...kbench/contrib/terminalContrib/commandGuide/browser/terminal.commandGuide.contribution.ts b/...kbench/contrib/terminalContrib/commandGuide/browser/terminal.commandGuide.contribution.ts
@@ -5,7 +5,7 @@
 
 import type { Terminal as RawXtermTerminal } from '@xterm/xterm';
 import { addDisposableListener } from '../../../../../base/browser/dom.js';
-import { combinedDisposable, Disposable, MutableDisposable } from '../../../../../base/common/lifecycle.js';
+import { combinedDisposable, Disposable, MutableDisposable, toDisposable } from '../../../../../base/common/lifecycle.js';
 import { localize } from '../../../../../nls.js';
 import { IConfigurationService } from '../../../../../platform/configuration/common/configuration.js';
 import { TerminalCapability } from '../../../../../platform/terminal/common/capabilities/capabilities.js';
@@ -70,6 +70,7 @@ class TerminalCommandGuideContribution extends Disposable implements ITerminalCo
 				addDisposableListener(viewportElement, 'mousemove', (e: MouseEvent) => this._tryShowHighlight(screenElement, xterm, e)),
 				addDisposableListener(xterm.raw.element!, 'mouseout', () => xterm.markTracker.showCommandGuide(undefined)),
 				xterm.raw.onData(() => xterm.markTracker.showCommandGuide(undefined)),
+				toDisposable(() => xterm.markTracker.showCommandGuide(undefined)),
 			);
 		}
 	}