Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for erroneous burst-fire effect stacking #1448

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BlackDog86
Copy link
Contributor

Fixes #1380

Tested with Knife rounds from MZ Perk pack (which applies 1 stack of bleeding @ 1 damage per instance) combined with Fan Fire and Cyclic Fire from the LW2 Gunner class pack. Correct amount of stacks seem to be applied - further testing required but looks good so far.

@BlackDog86 BlackDog86 requested a review from Iridar January 6, 2025 10:57
@BlackDog86 BlackDog86 self-assigned this Jan 6, 2025
@BlackDog86 BlackDog86 added this to the 1.30.0 milestone Jan 6, 2025
@BlackDog86 BlackDog86 changed the title Removed un-necessary code responsible for erroneous effect stacking Fix for erroneous effect stacking Jan 6, 2025
@BlackDog86 BlackDog86 changed the title Fix for erroneous effect stacking Fix for erroneous burst-fire effect stacking Jan 6, 2025
@Iridar
Copy link
Contributor

Iridar commented Jan 6, 2025

Looks fine, but please use per-line comments to comment out code, the // rather than /*, it's less messy. It would also be useful to mention that fix specifically is being accomplished just by commenting out the game's original code that does unnecessary special handling.

@BlackDog86 BlackDog86 force-pushed the 1380-BurstFire-Stacking-Fix branch from 887c081 to 3b87511 Compare January 7, 2025 01:30
@BlackDog86 BlackDog86 added the ready-to-review A pull request is ready to be reviewed label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-basegame ready-to-review A pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Burst Fire abilities that apply effects that can stack erroneouly multiply stacks by burst shots.
2 participants