Add check for Tick context to eHit_Crit and eHit-Graze #1443
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackDog86
force-pushed
the
1396-DOT-Crit-Graze-Fix
branch
from
74a898e to
fe50773
Compare
|
Looks good to me, if testing shows this works, this is okay to merge. |
|
I've tested this with dragon rounds and a couple of units with setStatonclosestunit eStat_dodge 100 to force a graze & the damage is definitely no longer adjusted by the graze but I've not tried it in a modded / campaign setting yet. |
Iridar
added
the
ready-for-merge
|
Ideally waiting on some more testing, but generally this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1396
Still needs a lot of testing before I'd be fully confident to merge.