Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoration Targeting Fix #1440

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Restoration Targeting Fix #1440

wants to merge 3 commits into from

Conversation

BlackDog86
Copy link
Contributor

@BlackDog86 BlackDog86 commented Jan 1, 2025 •
edited
Loading

Fixes #1436

@BlackDog86
Copy link
Contributor Author

Needs further stress testing but seemed to work fine in my preliminary round

@BlackDog86 BlackDog86 self-assigned this Jan 1, 2025
@BlackDog86 BlackDog86 added this to the 1.30.0 milestone Jan 1, 2025
@BlackDog86 BlackDog86 force-pushed the 1436-Restoration-Targeting-Fix branch from c91ab75 to b993eb6 Compare January 2, 2025 12:11
Iridar
Iridar requested changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@Iridar Iridar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fixing.

X2WOTCCommunityHighlander/Src/XComGame/Classes/X2Condition_Restoration.uc Show resolved Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/X2Condition_Restoration.uc Outdated Show resolved Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/X2Condition_Restoration.uc Outdated Show resolved Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/X2Condition_Restoration.uc Outdated Show resolved Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/X2Condition_Restoration.uc Outdated Show resolved Hide resolved
X2WOTCCommunityHighlander/Src/XComGame/Classes/X2Condition_Restoration.uc Outdated Show resolved Hide resolved
@Iridar Iridar added the waiting-on-author A pull request is waiting on changes from the author label Jan 4, 2025
@BlackDog86 BlackDog86 force-pushed the 1436-Restoration-Targeting-Fix branch from b993eb6 to 31bf74a Compare January 4, 2025 15:24
@BlackDog86 BlackDog86 added ready-to-review A pull request is ready to be reviewed and removed waiting-on-author A pull request is waiting on changes from the author labels Jan 4, 2025
@Iridar Iridar added ready-for-merge the pull request was reviewed and is ready to be merged. and removed ready-to-review A pull request is ready to be reviewed labels Jan 6, 2025
@Iridar
Copy link
Contributor

Iridar commented Jan 6, 2025

Looks good, though I wish it was possible to fix this without replacing X2Conditions on the ability. I'd like to get some testing done on this before merging, but otherwise this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iridar Iridar Iridar requested changes

Assignees

@BlackDog86 BlackDog86

Labels
bug-basegame ready-for-merge the pull request was reviewed and is ready to be merged.
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.

Restoration can't be activated if the squad is not missing HP
2 participants
@BlackDog86 @Iridar