Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an overridable function to X2AbilityToHitCalc_StandardAim::GetHitChance() #1272

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Add an overridable function to X2AbilityToHitCalc_StandardAim::GetHitChance() #1272

merged 3 commits into from
Oct 28, 2023

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Oct 22, 2023 •
edited
Loading

Fixes #1271

Tested, works.

@Iridar Iridar added enhancement ready-to-review A pull request is ready to be reviewed labels Oct 22, 2023
@Iridar Iridar added this to the 1.27.0 milestone Oct 22, 2023
@Iridar Iridar self-assigned this Oct 22, 2023
@Iridar Iridar merged commit 5c5b943 into X2CommunityCore:master Oct 28, 2023
4 checks passed
@Iridar Iridar deleted the 1271-GetAdditionalModifiers_CH branch October 28, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Iridar Iridar

Labels
enhancement ready-to-review A pull request is ready to be reviewed
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.

X2AbilityToHitCalc::GetHitChance() is annoying to override in subclasses
2 participants
@Iridar @ps2guides