Skip to content

Commit

Permalink
Revert "Implement Issue #1213"
Browse files Browse the repository at this point in the history
This reverts commit 9490789.
  • Loading branch information
ps2guides committed Aug 21, 2023
1 parent 7a4ee66 commit 29b140c
Showing 1 changed file with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,7 @@ protected function int GetHitChance(XComGameState_Ability kAbility, AvailableTar
else if (bIndirectFire)
{
m_ShotBreakdown.HideShotBreakdown = true;

/// HL-Docs: ref:Bugfixes; issue:1213
/// Treat bIndirectFire same as bGuaranteedHit for the purposes of hit chance modifiers.
super.AddModifier(100, AbilityTemplate.LocFriendlyName, m_ShotBreakdown, eHit_Success, bDebugLog);
AddModifier(100, AbilityTemplate.LocFriendlyName, m_ShotBreakdown, eHit_Success, bDebugLog);
}

// Issue #346: AddModifier(BuiltIn...Mod) block moved later in method.
Expand Down Expand Up @@ -879,9 +876,7 @@ function int GetModifiedHitChanceForCurrentDifficulty(XComGameState_Player Insti

protected function AddModifier(const int ModValue, const string ModReason, out ShotBreakdown m_ShotBreakdown, EAbilityHitResult ModType = eHit_Success, bool bDebugLog = false)
{
/// HL-Docs: ref:Bugfixes; issue:1213
/// Treat bIndirectFire same as bGuaranteedHit for the purposes of hit chance modifiers.
if (bGuaranteedHit || m_ShotBreakdown.SpecialGuaranteedHit != '' || bIndirectFire)
if (bGuaranteedHit || m_ShotBreakdown.SpecialGuaranteedHit != '')
{
if (ModType != eHit_Crit) // for a guaranteed hit, the only possible modifier is to allow for crit
return;
Expand Down

0 comments on commit 29b140c

Please sign in to comment.