[Snyk] Upgrade react-modal from 3.11.2 to 3.16.3 #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk has created this PR to upgrade react-modal from 3.11.2 to 3.16.3. See this package in npm: react-modal See this project in Snyk: https://app.snyk.io/org/sammytezzy/project/40ca3cc4-73c7-4f07-9d5c-d0de7f61bd28?utm_source=github&utm_medium=referral&page=upgrade-pr
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deployment failed with the following error: |
|
|
Reviewer's Guide by SourceryThis pull request upgrades Sequence diagram for modal keyboard interaction changessequenceDiagram
participant U as User
participant M as Modal
participant K as Keyboard Handler
U->>M: Press key
Note over K: Changed from keyCode to KeyboardEvent.code
M->>K: Handle keyboard event
K-->>M: Process key action
M-->>U: Update modal state
Class diagram showing react-modal version upgradeclassDiagram
class ReactModal {
version: string
+allowReactV18()
+supportShadowDOM()
+handleKeyboardEvents()
+preventScroll()
}
note for ReactModal "Upgraded from v3.11.2 to v3.16.3"
class Features {
+ariaModalAttribute
+customOverlayElement
+customContentElement
+preventScroll
+testIdProp
}
ReactModal --> Features : includes
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to upgrade react-modal from 3.11.2 to 3.16.3.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 10 versions ahead of your current version.
The recommended version was released a month ago.
Release notes
Package name: react-modal
-
3.16.3 - 2024-12-17
- a5c0cf4 removing restriction on node engines.
-
3.16.2 - 2024-12-17
- b91c724 updade react and react-dom peer dependencies.
- a275399 simplify PR template.
- 588f26b contributing requirements now just need a corresponding issue... on GitHub board
- 449398d remove discussion note from readme.
- e4841d6 chore: update shouldCloseOnOverlayClick doc
- 6724a04 Fix tests
- 7c1d947 Fix badge
- 96a81be Comment the ellipsis in code blocks in docs/index.md
- aff8b91 [added] add nodejs version restriction to package.json
- 321966e [changed] change Miscellaneous related nodejs version text
- 8dc2347 [added] add Miscellaneous section to the contributions.md file
- f9bc6a0 [fixed] strict matching for tabbable nodes
- e7c4a63 downgrade node version on github action.
- 1a8f562 running tests on github actions
-
3.16.1 - 2022-10-18
- [fixed]: css class added to root document instead of modal ownerDocument by @ leoc4e in #965
- update broken build badge by @ memark in #968
- [fixed] element with display 'contents' is visible and is tabbable by @ galexandrade in #969
- [fixed] switched from KeyboardEvent.keyCode to KeyboardEvent.code by @ robinmetral in #953
- @ leoc4e made their first contribution in #965
- @ memark made their first contribution in #968
- @ galexandrade made their first contribution in #969
- @ robinmetral made their first contribution in #953
-
3.15.1 - 2022-04-27
- 8395a21 allow react 18 as peer dependency
- 68af7ec [added] tabbable support for iframes
- 28986ea Fix typo in docs
-
3.14.4 - 2021-11-10
- Ensure that we know about every "tabbable" element within Shadow DOM
- Correctly wrap NODE_ENV conditional code in block to eliminate unreachable code
- Updated some dependencies
-
3.14.3 - 2021-06-15
- b33923a [changed]: Updated and formatted example in README
- 0847049 [fixed] Cancel requested animation frame on unmount.
- fc76b0c [chore] added link to the discussion for react-modal v4.
- 0d99156 [chore] Don't allow mkdocs.yml be included on releases.
-
3.14.2 - 2021-06-02
- 172879e [chore] Don't allow .log in on releases.
-
3.14.1 - 2021-06-02
- fc62ab1 Fixing lint error and PR suggestion change to use double quotes
- ce94d86 Working on lint error
- 7e732d7 Wrapping getComputedStyle in try catch per PR review
- 31d59b2 Adding a check to see if the element is a prototype of Element before getting the computed style
- 827796d [fixed] Ensure after-open css transitions work in Safari 14 & Mobile Safari
- 76df16b [chore] regenerate package-lock.
- 4fbe228 bump prop-types to 15.7.2
- a5f959a [chore] update packages.
- 8050773 [chore] clean up all element leaks between tests.
-
3.13.1 - 2021-04-13
- 5832904 Updated README.md
- d7083c5 [added] docs note about setAppElement not pruning removed nodes
- e1807ce [added] support Array, HTMLCollection and NodeList values for appElement
- c9d8e2d Bump ini from 1.3.5 to 1.3.8
- 8d4ef84 fixed(documentation): jsx-lexer now requires to generate a css file...
- ab8c44c fixed(documentation): link to app-element on index.
-
3.12.1 - 2020-11-23
- 029a525 Added react 17 support
- 694d425 fix #833 by changing stale link from
- 9ca3626 [fixed] add aria-modal attribute
- b2e58e7 [fixed] extra 'p' character in index.md
- 94ad567 [fixed] don't access ReactDOM.createPortal if DOM not available
- 421a1c8 chore(lint): run lint.
- c797e9a [added] Added custom overlayElement and contentElement.
- fa98fcc [fixed] check before react-modal removal from parent element that parent has it
- ff0a7f5 [added] a preventScroll prop
- 2ea6d44 Add '--save'
- eea891c Update package.json
- 6417a6a fixed(chore): update packages.
- bd07d56 Adds testId prop and useage to documentation
- 4a120a9 fix linting
- 206cfe6 ensure focus does not scroll the modal
- 9a4dde5 [fixed] - Fix broken links of codepen in examples in docs
-
3.11.2 - 2020-02-26
from react-modal GitHub release notesWhat's Changed
New Contributors
Full Changelog: https://github.com/reactjs/react-modal/blob/master/CHANGELOG.md
README.mdImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
Summary by Sourcery
Enhancements:
with-route-as-modalexample.