Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ch02-03.assignment.md #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pitaohc
Copy link

@pitaohc pitaohc commented Mar 19, 2024

fix 修复ch02-03.assignment中的逻辑错误。GetGlobal字节码是得到全局变量并复制到栈上。

fix 修复ch02-03.assignment中的逻辑错误。GetGlobal字节码是得到全局变量并复制到栈上
@WuBingzheng
Copy link
Owner

多谢fix。

我看文件diff里,最后一行也变了。是因为行尾的换行符吗?麻烦修一下吧,避免这个无谓的diff。

@pitaohc
Copy link
Author

pitaohc commented Mar 25, 2024

我提交了一个新的commit删除了文件最后的换行符,这样修改可以吗。还是我这边需要关闭这个pull request重新提交一个?

@WuBingzheng
Copy link
Owner

新commit就行,不用新pr。

不过你最近的这个commit里好像什么都没改?
我看pr的文件diff里,还是有最后一行的diff。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants