Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagram of remake #399

Closed
wants to merge 1 commit into from
Closed

Add diagram of remake #399

wants to merge 1 commit into from

Conversation

mezotv
Copy link
Member

@mezotv mezotv commented Jan 6, 2024

This adds a diagram to show how the remake is going to work.

Would You Remake

Please let me know what you think!

Copy link
Contributor

@Sans3108 Sans3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@Nidrux Nidrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change out cluster for bot and the wrapping square can be named cluster.

Maybe more vibrant colors? More vibrant background? (Like the one you showed me but then with would you colors?)

@Nidrux
Copy link
Member

Nidrux commented Jan 6, 2024

I would change out cluster for bot and the wrapping square can be named cluster.

Maybe more vibrant colors? More vibrant background? (Like the one you showed me but then with would you colors?)

Also find a system in colors. This can be useful later on when we scale up more. This is so we know what color corresponds to what type of service. Databases green? caches red? Queue's orange?

@mezotv
Copy link
Member Author

mezotv commented Jan 6, 2024

I would change out cluster for bot and the wrapping square can be named cluster.

I called them clusters because the queue system is spread into multiple clusters not multiple bots. So this would make more sense.

@mezotv
Copy link
Member Author

mezotv commented Jan 7, 2024

Also find a system in colors. This can be useful later on when we scale up more. This is so we know what color corresponds to what type of service. Databases green? caches red? Queue's orange?

Give me some time and I will be working on a design document with all the colors etc.

@mezotv mezotv marked this pull request as draft January 7, 2024 08:01
@forgetfulskybro
Copy link
Member

Looks pretty good though maybe we should add descriptions to each box so people will understand what they mean. Anyone else like this idea?

@mezotv
Copy link
Member Author

mezotv commented Jan 7, 2024

Looks pretty good though maybe we should add descriptions to each box so people will understand what they mean. Anyone else like this idea?

I can add that to the design document sure!

@forgetfulskybro forgetfulskybro marked this pull request as ready for review January 9, 2024 15:41
@forgetfulskybro
Copy link
Member

Oops accidentally clicked that button. Meant to put my approval 😄

@mezotv mezotv closed this Mar 24, 2024
@forgetfulskybro forgetfulskybro deleted the diagram branch June 25, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants