Skip to content

Commit

Permalink
Merge pull request #51 from Workiva/batch/fedx/workiva_analysis_optio…
Browse files Browse the repository at this point in the history
…ns_v2

FEDX-1709 Batch/fedx/workiva analysis options v2
  • Loading branch information
rmconsole2-wf authored Nov 15, 2024
2 parents 9e97f96 + eef8af1 commit 0be6c5a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 11 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/dart_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ 2.19.6, stable, beta ]
sdk: [ 2.19.6 ]
# TODO: Add stable and beta sdk's as a separate effort (FEDX-1911)[https://jira.atl.workiva.net/browse/FEDX-1911]
# sdk: [ 2.19.6, stable, beta ]
steps:
- uses: actions/checkout@v4
- uses: dart-lang/setup-dart@v1
Expand All @@ -46,7 +48,9 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ 2.19.6, stable, beta ]
sdk: [ 2.19.6 ]
# TODO: Add stable and beta sdk's as a separate effort (FEDX-1911)[https://jira.atl.workiva.net/browse/FEDX-1911]
# sdk: [ 2.19.6, stable, beta ]
steps:
- uses: actions/checkout@v4
- uses: dart-lang/setup-dart@v1
Expand Down
9 changes: 1 addition & 8 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
include: package:pedantic/analysis_options.1.8.0.yaml

include: package:workiva_analysis_options/v2.yaml
analyzer:
exclude:
- example/**
- lib/**.g.dart
language:
strict-inference: true
strict-raw-types: true

linter:
rules:
- avoid_types_on_closure_parameters
- prefer_void_to_null
- void_checks
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ dev_dependencies:
build_test: ^2.1.3
build_web_compilers: '>=3.0.0 <5.0.0'
dependency_validator: ^3.1.0
pedantic: ^1.11.1
test_descriptor: ^2.0.0
test_process: ^2.0.2
workiva_analysis_options: ^1.4.1

# If changes are made to `lib/src/config.dart` and regeneration is needed,
# uncomment this and comment out the test_html_builder definition in
Expand Down

0 comments on commit 0be6c5a

Please sign in to comment.