Merge pull request #44 from Workiva/regexp-escape-testids

Fix test ID queries not properly escaping RegExps

lib/src/dom/queries/by_testid.dart

@@ -445,7 +445,9 @@ external List< /*Element*/ dynamic> _jsQueryAllByTestId(
 dynamic _convertTestIdStringToRegExp(dynamic testId, {bool exact = true}) {
   if (testId is! String) return TextMatch.toJs(testId);
 
-  final testIdMatcher = exact ? RegExp('(\\s|^)$testId(\\s|\$)') : RegExp('(.?)$testId(.?)', caseSensitive: false);
+  final testIdMatcher = exact
+      ? RegExp('(\\s|^)${RegExp.escape(testId as String)}(\\s|\$)')
+      : RegExp('(.?)${RegExp.escape(testId as String)}(.?)', caseSensitive: false);
 
   return TextMatch.toJs(testIdMatcher);
 }

test/unit/dom/queries/by_testid_test.dart

@@ -189,6 +189,16 @@ void main() {
         });
       });
 
+      test(
+          'works when test IDs contain regular expression syntax'
+          ' (by properly escaping the test ID when incorporating it into a RegExp)', () {
+        final view = rtl.render(react.span({
+          'data-test-id': 'testId(1)',
+        }) as ReactElement);
+
+        expect(view.getByTestId('testId(1)'), isA<SpanElement>());
+      });
+
       group('with the "exact: false" argument', () {
         group('getByTestId', () {
           test('[non-exact string match]', () {
@@ -255,6 +265,16 @@ void main() {
             expect(await view.findAllByTestId('estid-2', exact: false), hasLength(2));
           });
         });
+
+        test(
+            'works when test IDs contain regular expression syntax'
+            ' (by properly escaping the test ID when incorporating it into a RegExp)', () {
+          final view = rtl.render(react.span({
+            'data-test-id': 'testId(1)',
+          }) as ReactElement);
+
+          expect(view.getByTestId('estId(1)', exact: false), isA<SpanElement>());
+        });
       });
     });
 

test/unit/dom/wait_for_test.dart

@@ -456,5 +456,6 @@ void main() {
         }, timeout: asyncQueryTestTimeout);
       });
     });
-  });
+    // Attempt to fix flaky timeout failures in CI
+  }, tags: 'run-alone');
 }