Fix some lints

Workiva · Nov 15, 2023 · 23904de · 23904de
1 parent 363dade
commit 23904de
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/lib/src/builder/codegen/component_generator.dart b/lib/src/builder/codegen/component_generator.dart
@@ -28,10 +28,10 @@ abstract class ComponentGenerator extends BoilerplateDeclarationGenerator {
   factory ComponentGenerator.legacy(LegacyClassComponentDeclaration declaration, {required bool nullSafety}) =
       _LegacyComponentGenerator;
 
-  late TypedMapNames propsNames;
-  TypedMapNames? stateNames;
-  late ComponentNames componentNames;
-  late FactoryNames factoryNames;
+  TypedMapNames get propsNames;
+  TypedMapNames? get stateNames;
+  ComponentNames get componentNames;
+  FactoryNames get factoryNames;
 
   BoilerplateComponent get component;
   bool get hasState;

diff --git a/lib/src/builder/parsing/member_association.dart b/lib/src/builder/parsing/member_association.dart
@@ -161,5 +161,8 @@ String? getRelatedName(BoilerplateMember member) {
 }
 
 extension<T> on T? {
-  S? mapIfNotNull<S>(S? Function(T) callback) => this == null ? null : callback(this!);
+  S? mapIfNotNull<S>(S? Function(T) callback) {
+    final self = this;
+    return self == null ? null : callback(self);
+  }
 }
diff --git a/lib/src/builder/parsing/meta.dart b/lib/src/builder/parsing/meta.dart
@@ -122,7 +122,7 @@ class InstantiatedComponentMeta<TMeta> extends InstantiatedMeta<TMeta> {
         subtypeOfValue = expression;
         instantiated.unsupportedArguments.remove(subtypeOfParam);
       } else {
-        throw '`$_subtypeOfParamName` must be an identifier: $subtypeOfParam';
+        throw Exception('`$_subtypeOfParamName` must be an identifier: $subtypeOfParam');
       }
     }
 

diff --git a/lib/src/component_declaration/builder_helpers.dart b/lib/src/component_declaration/builder_helpers.dart
@@ -190,7 +190,7 @@ abstract class UiProps extends component_base.UiProps with GeneratedClass {
   }
 }
 
-class MissingRequiredPropsError {
+class MissingRequiredPropsError extends Error {
   final String _message;
 
   MissingRequiredPropsError(this._message);

diff --git a/lib/src/util/prop_key_util.dart b/lib/src/util/prop_key_util.dart
@@ -77,7 +77,7 @@ class _SingleKeyAccessMapSpy extends MapBase {
 }
 
 // FIXME document, add test cases (especially for non-nullable props).
-class KeyAccessedException {
+class KeyAccessedException implements Exception {
   final Object? key;
 
   KeyAccessedException(this.key);