-
Notifications
You must be signed in to change notification settings - Fork 844
RM-27055 added Queue methods: GetItems, GetItem, Search, Clear #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikepan
wants to merge
2
commits into
Workiva:master
Choose a base branch
from
nikepan:queue_additions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -145,6 +145,25 @@ func (items *items) getUntil(checker func(item interface{}) bool) []interface{} | |
return returnItems | ||
} | ||
|
||
func (items *items) getMatch(checker func(item interface{}) bool) []interface{} { | ||
length := len(*items) | ||
|
||
if len(*items) == 0 { | ||
// returning nil here actually wraps that nil in a list | ||
// of interfaces... thanks go | ||
return []interface{}{} | ||
} | ||
|
||
returnItems := make([]interface{}, 0, length) | ||
for _, item := range *items { | ||
if !checker(item) { | ||
returnItems = append(returnItems, item) | ||
} | ||
} | ||
|
||
return returnItems | ||
} | ||
|
||
type sema struct { | ||
ready chan bool | ||
response *sync.WaitGroup | ||
|
@@ -323,6 +342,51 @@ func (q *Queue) Len() int64 { | |
return int64(len(q.items)) | ||
} | ||
|
||
// GetItems returns items in this queue. | ||
func (q *Queue) GetItems() []interface{} { | ||
q.lock.Lock() | ||
defer q.lock.Unlock() | ||
|
||
return q.items | ||
} | ||
|
||
// Search takes a function and returns a list of items that | ||
// match the checker. This does not wait and remove items. | ||
func (q *Queue) Search(checker func(item interface{}) bool) ([]interface{}) { | ||
if checker == nil { | ||
return nil | ||
} | ||
|
||
q.lock.Lock() | ||
|
||
if q.disposed { | ||
q.lock.Unlock() | ||
return nil | ||
} | ||
|
||
result := q.items.getMatch(checker) | ||
q.lock.Unlock() | ||
return result | ||
} | ||
|
||
|
||
// GetItem returns one item without deleting in this queue. | ||
func (q *Queue) GetItem(pos int) (interface{}, bool) { | ||
q.lock.Lock() | ||
defer q.lock.Unlock() | ||
if len(q.items) > pos { | ||
return q.items[pos], true | ||
} | ||
return nil, false | ||
} | ||
|
||
// GetItems returns items in this queue. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment doesn't seem to define the exact behavior. |
||
func (q *Queue) Clear(hint int64) { | ||
q.lock.Lock() | ||
defer q.lock.Unlock() | ||
q.items = make([]interface{}, 0, hint) | ||
} | ||
|
||
// Disposed returns a bool indicating if this queue | ||
// has had disposed called on it. | ||
func (q *Queue) Disposed() bool { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to me it seems unintuitive that this would return objects that do not pass checker, I'd expect the opposite behavior