-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEDX-812 Improve CLI ergonomics #6
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment. ✅ Required actions successful General InformationTicket(s): Code Review(s): #6 Reviewers: evanweible-wf, matthewnitschke-wk Additional InformationWatchlist Notifications: None
Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
- Always require that the first position arg is a package spec - Always run via `dart pub global run` by default - Allow package-executable to be set explicitly with a trailing `:<exe>` on the package spec - Add `-e <executable>` option to override the executable that gets run, allowing a way to opt out of the `dart pub global run` approach.
64bc890
to
42b8e97
Compare
```bash | ||
dart pub global activate -sgit [email protected]:Workiva/dpx.git | ||
dart pub global activate dpx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like dpx is on the public pub server yet
Is this change just in preparation for this to happen soon? or should we add --hosted-url
on this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was planning to open source and publish once this change lands 👍
QA +1
|
@Workiva/release-management-p |
@evanweible-wf I will not merge this because:
|
RM +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Could not merge pull request. For assistance, reach out to a member of Release Management in the '#support-release' Slack channel Error: 5 of 7 required status checks are expected. |
1 similar comment
Could not merge pull request. For assistance, reach out to a member of Release Management in the '#support-release' Slack channel Error: 5 of 7 required status checks are expected. |
Motivation
Currently, in order to "override" the command that gets run when using dpx, you have to specify the package source by adding
-p
and then changing via the first arg, whereas otherwise the-p
arg is not required and is inferred from the first arg.So for example:
This is awkward because it's not obvious when the -p format should be used.
Changes
A few changes are made in this PR to improve the overall ergonomics of the CLI:
dart pub global run
by default:<exe>
on the package spec-e <executable>
option to override the executable that gets run, allowing a way to opt out of thedart pub global run
approach.