Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-1727: Support organizeDirectives config via hackFastFormat #438

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Sep 17, 2024

FEDX-1727

Issue Status

The hackFastFormat command is used by some of our dev tooling like IDE auto-formatting and precommit hooks. It does not currently support organizing directives, whereas the full format command does.

This PR updates hackFastFormat to check the project's ddev config to see if it has enabled organizeDirectives, and if so, it ensures that the format tool it sets up matches that configuration. In other words, hackFastFormat should now respect the organizeDirectives configuration of the project it is running in, which should allow IDE auto-formatting and precommit hooks that use hackFastFormat to match behavior of running ddev format.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole5-wk rmconsole5-wk changed the title Support organizeDirectives config via hackFastFormat FEDX-1727 Support organizeDirectives config via hackFastFormat Oct 9, 2024
@bender-wk bender-wk changed the title FEDX-1727 Support organizeDirectives config via hackFastFormat FEDX-1727: Support organizeDirectives config via hackFastFormat Oct 9, 2024
@evanweible-wf evanweible-wf marked this pull request as ready for review October 9, 2024 15:51
@evanweible-wf evanweible-wf requested a review from a team as a code owner October 9, 2024 15:51
@evanweible-wf
Copy link
Contributor Author

QA +1

@evanweible-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit cc36448 into master Oct 9, 2024
7 checks passed
@rmconsole7-wk rmconsole7-wk deleted the hackFastFormat-support-organizeDirectives branch October 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants