fix missing init of main menu popup in G3X (#1269)

* fix missing init of main menu popup in G3X * remove superfluous console.logs
Working-Title-MSFS-Mods · Jul 27, 2021 · c3815d8 · c3815d8
1 parent e4029af
commit c3815d8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/PackageDefinitions/workingtitle-gx-metapackage.xml b/PackageDefinitions/workingtitle-gx-metapackage.xml
@@ -1,4 +1,4 @@
-<AssetPackage Name="workingtitle-gx" Version="0.1.0-dev9">
+<AssetPackage Name="workingtitle-gx" Version="0.1.0-dev10">
 	<ItemSettings>
 		<ContentType>CUSTOM</ContentType>
 		<Title>Working Title GX</Title>

diff --git a/README.md b/README.md
@@ -14,6 +14,5 @@ Project | Description | Current Version | Documentation
 --------|-------------|-----------------|--------------
 CJ4 | OPEN BETA - Performance and avionics improvements for the Citation CJ4 | [v0.12.6](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/cj4-v0.12.6) | [docs](https://github.com/Working-Title-MSFS-Mods/fspackages/tree/main/docs/workingtitle-cj4)
 G1000 | Fixes and enhancements for the stock G1000 avionics package | [v0.4.0](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/g1000-v0.4.0) | [docs](https://github.com/Working-Title-MSFS-Mods/fspackages/tree/main/docs/workingtitle-g1000)
-G3000 | Fixes and enhancements for the stock G3000 avionics package | [v0.7.4](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/g3000-v0.7.4a) | [docs](https://github.com/Working-Title-MSFS-Mods/fspackages/tree/main/docs/workingtitle-g3000)
-GX | Fixes and enhancements for the stock G3X Touch avionics package | [v0.1.0-dev9](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/gx-v0.1.0-dev9) | [docs](https://github.com/Working-Title-MSFS-Mods/fspackages/tree/main/docs/workingtitle-gx)
-
+G3000 | Fixes and enhancements for the stock G3000 avionics package | [v0.7.4](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/g3000-v0.7.4) | [docs](https://github.com/Working-Title-MSFS-Mods/fspackages/tree/main/docs/workingtitle-g3000)
+GX | Fixes and enhancements for the stock G3X Touch avionics package | [v0.1.0-dev10](https://github.com/Working-Title-MSFS-Mods/fspackages/releases/tag/gx-v0.1.0-dev10) | [docs](https://github.com/Working-Title-MSFS-Mods/fspackages/tree/main/docs/workingtitle-gx)
diff --git a/docs/workingtitle-gx/CHANGES.md b/docs/workingtitle-gx/CHANGES.md
@@ -1,3 +1,6 @@
+# Changes in 0.1.0-dev10
+* Fix bug that caused menu button to not open main MFD menu.
+
 # Changes in 0.1.0-dev9
 * Compatibility with SU5.
 

diff --git a/...ms-gx/html_ui/WorkingTitle/Pages/VCockpit/Instruments/NavSystems/AS3X_Touch/AS3X_Touch.js b/...ms-gx/html_ui/WorkingTitle/Pages/VCockpit/Instruments/NavSystems/AS3X_Touch/AS3X_Touch.js
@@ -772,13 +772,13 @@ class AS3X_Touch_Popup extends NavSystemElement {
         this.root = root;
     }
     onEnter() {
-        this.root.setAttribute("state", "Active");
+        diffAndSetAttribute(this.root, "state", "Active");
     }
     onUpdate() {
         super.onUpdate();
     }
     onExit() {
-        this.root.setAttribute("state", "Inactive");
+        diffAndSetAttribute(this.root, "state", "Inactive");
     }
     onEvent(_event) {
     }
@@ -841,6 +841,7 @@ class AS3X_Touch_AFCSMenu extends AS3X_Touch_Popup {
 }
 class AS3X_Touch_PageMenu extends AS3X_Touch_Popup {
     init(root) {
+        super.init(root);
         this.buttons = [];
         this.menuElements = root.getElementsByClassName("menuElements")[0];
     }