Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json devDependency versions #544

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Feb 17, 2025

While investigating #541 and #542 I tried updating the modules, I guess we should probably do that at some point? I don't know what (if anything) this would break/fix.

@dd32 dd32 changed the title Try/update modules Update package.json devDependency versions Feb 17, 2025
@ryelle
Copy link
Contributor

ryelle commented Feb 17, 2025

I guess we should probably do that at some point? I don't know what (if anything) this would break/fix.

A quick glance at the changelogs, not much for env, some new linter rules in eslint-plugin, scripts updated stylelint, and I don't know about puppeteer — I think we're just using that for the screenshot changes though.

The lint error here is due to the scripts' stylelint upgrade, I have a PR into the repo-tools repo to update the stylelint rules: WordPress/wporg-repo-tools#32

Is it possible to tell composer to install that branch of repo-tools? I don't think we can merge that until all the projects can be updated. Actually… if we switch to a js config file for stylelint, maybe we can check the scripts version and conditionally load the correct rules… I can try that out in repo-tools this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants