-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download all WordPress assets on boot #1532
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6d9e165
ZIP WP assets
bgrgicak 75bc2bb
Add afterWordPressInstall hook to boot
bgrgicak 6c2b0ad
Download assets after WordPress is installed
bgrgicak 57daebb
Merge branch 'trunk' into add/wp-static-asset-zip
bgrgicak 42be4fc
Use getWordPressVersionFromPhp
bgrgicak 8beee0c
Remove bootWordPress hook
bgrgicak 6cf5fef
Use wordPressSiteUrl
bgrgicak 1f2347e
Stream static asset response instead of awaiting
bgrgicak f1e2784
Use request handler to get document root
bgrgicak 3c98912
Add warning if assets weren't downloaded
bgrgicak e703eff
Merge branch 'trunk' into add/wp-static-asset-zip
bgrgicak 2e3910c
Async fetch
bgrgicak d2ca9c2
Update error messages
bgrgicak 4a1f8d0
Use wpVersionToStaticAssetsDirectory
bgrgicak efb4b57
Use getLoadedWordPressVersion
bgrgicak b2ba22b
downloadWordPressAssets on load
bgrgicak 1aad0d0
Remove logs
bgrgicak db8c25f
Merge branch 'trunk' into add/wp-static-asset-zip
bgrgicak de206a1
Merge branch 'trunk' into add/wp-static-asset-zip
bgrgicak a6f20bd
Empty remote asset paths after done instead of deleting it, update co…
bgrgicak ebfa224
Merge branch 'trunk' into add/wp-static-asset-zip
bgrgicak 37c0b91
Update packages/playground/remote/src/lib/worker-thread.ts
bgrgicak ee044ae
Linter fixes
bgrgicak f8dab44
Build static assets
bgrgicak 6f48337
Use unzipFile
bgrgicak d34f066
Fix dependencies
bgrgicak 1feb41a
Update static asset zips
bgrgicak f3fe08d
Merge branch 'trunk' into add/wp-static-asset-zip
bgrgicak f0378d0
Remove unused zip delete
bgrgicak 7c205fa
Update remote asset PR comment
bgrgicak e03c9ad
Merge branch 'trunk' into add/wp-static-asset-zip
bgrgicak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+11.2 MB
packages/playground/wordpress-builds/public/wp-6.2/wordpress-static.zip
Binary file not shown.
Binary file added
BIN
+11.6 MB
packages/playground/wordpress-builds/public/wp-6.3/wordpress-static.zip
Binary file not shown.
Binary file added
BIN
+12.9 MB
packages/playground/wordpress-builds/public/wp-6.4/wordpress-static.zip
Binary file not shown.
Binary file added
BIN
+13 MB
packages/playground/wordpress-builds/public/wp-6.5/wordpress-static.zip
Binary file not shown.
Binary file added
BIN
+12.8 MB
packages/playground/wordpress-builds/public/wp-beta/wordpress-static.zip
Binary file not shown.
Binary file added
BIN
+12.9 MB
packages/playground/wordpress-builds/public/wp-nightly/wordpress-static.zip
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgrgicak I'd still rewrite this entire comment for clarity and probably make it at least 2-3 times as long as it is now. A few thing that stood out for me were:
wordpress-remote-asset-paths
? I understand it is a file because I have the context fresh in my head, but I don't quite get it from the comment. What would be an example of the content of that file? Or, if not an inline example here, where can I go to see it?This could be a docblock for the entire
backfillStaticFilesRemovedFromMinifiedBuild
function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmsnell authored one of the best examples I know of what useful, high-quality inline documentation looks like:
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php