Skip to content

Commit

Permalink
Fix mbregex support (#1155)
Browse files Browse the repository at this point in the history
Fixes #815

## What is this PR doing?

It fixes support for `mbregex` and adds a test to ensure it keeps
working.

## What problem is it solving?

Ensures support for `mbregex`.

## How is the problem addressed?

By fixing a `if` condition in the Docker file that prevented PHP > 7.0
from enabling `mbregex`.
Also, the code wrongly assumed that PHP 7.4 includes `oniguruma`, but it
doesn't, so it's now added to PHP 7.4.

## Testing Instructions
- ensure tests pass
  • Loading branch information
bgrgicak authored Apr 1, 2024
1 parent f527835 commit 88c043c
Show file tree
Hide file tree
Showing 56 changed files with 53 additions and 31 deletions.
8 changes: 4 additions & 4 deletions packages/php-wasm/compile/php/Dockerfile
Binary file modified packages/php-wasm/node/public/7_0_33/php_7_0.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/7_1_30/php_7_1.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/7_2_34/php_7_2.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/7_3_33/php_7_3.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/7_4_33/php_7_4.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/8_0_30/php_8_0.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/8_1_23/php_8_1.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/8_2_10/php_8_2.wasm
Binary file not shown.
Binary file modified packages/php-wasm/node/public/8_3_0/php_8_3.wasm
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_7_0.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_7_1.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_7_2.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_7_3.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_7_4.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_8_0.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_8_1.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_8_2.js
2 changes: 1 addition & 1 deletion packages/php-wasm/node/public/php_8_3.js
22 changes: 22 additions & 0 deletions packages/php-wasm/node/src/test/php.spec.ts
Binary file modified packages/php-wasm/web/public/kitchen-sink/7_0_33/php_7_0.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/7_1_30/php_7_1.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/7_2_34/php_7_2.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/7_3_33/php_7_3.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/7_4_33/php_7_4.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/8_0_30/php_8_0.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/8_1_23/php_8_1.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/8_2_10/php_8_2.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/kitchen-sink/8_3_0/php_8_3.wasm
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_7_0.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_7_1.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_7_2.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_7_3.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_7_4.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_8_0.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_8_1.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_8_2.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/kitchen-sink/php_8_3.js
Binary file modified packages/php-wasm/web/public/light/7_0_33/php_7_0.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/7_1_30/php_7_1.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/7_2_34/php_7_2.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/7_3_33/php_7_3.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/7_4_33/php_7_4.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/8_0_30/php_8_0.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/8_1_23/php_8_1.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/8_2_10/php_8_2.wasm
Binary file not shown.
Binary file modified packages/php-wasm/web/public/light/8_3_0/php_8_3.wasm
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_7_0.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_7_1.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_7_2.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_7_3.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_7_4.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_8_0.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_8_1.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_8_2.js
2 changes: 1 addition & 1 deletion packages/php-wasm/web/public/light/php_8_3.js

0 comments on commit 88c043c

Please sign in to comment.