-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/Test Tools: Update wp-prettier to 3.0.3 and refine ESLint ignore patterns #8295
Build/Test Tools: Update wp-prettier to 3.0.3 and refine ESLint ignore patterns #8295
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@Infinite-Null Taking a look at this, the update of |
Hi @aaronjorbin, Thank you for your feedback! I added those ignore rules because when I ran Please guide me if I am wrong. |
Thanks for the quick response and explanation. I think bringing
|
Hi @aaronjorbin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, thanks. I see a couple of spots where there could be some more consistency.
.eslintignore
Outdated
@@ -1,15 +1,31 @@ | |||
# Files and folders related to build/test tools | |||
/build | |||
/node_modules | |||
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build | |
/build |
Keep it similiar to https://github.com/WordPress/wordpress-develop/blob/trunk/.gitignore#L22
.eslintignore
Outdated
build-module | ||
build-types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-module | |
build-types |
Core does not generate folders with this name
.eslintignore
Outdated
build | ||
build-module | ||
build-types | ||
node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node_modules | |
/node_modules |
Same as https://github.com/WordPress/wordpress-develop/blob/trunk/.gitignore#L20
.eslintignore
Outdated
/jsdoc | ||
/artifacts | ||
/coverage | ||
/.cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/.cache | |
.cache/* |
https://github.com/WordPress/wordpress-develop/blob/trunk/.gitignore#L14
.eslintignore
Outdated
|
||
# Excluded files and folders based on `jsdoc.conf.json` exclusions | ||
/src/js/_enqueues/vendor | ||
|
||
# Webpack built files | ||
/src/wp-includes/js/media-* | ||
/src/wp-includes/js | ||
*.min.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*.min.js |
I think this is no longer necessary based on the other changes.
Hi @aaronjorbin, |
Committed in https://core.trac.wordpress.org/changeset/59848 Thanks @Infinite-Null ! |
Trac ticket: #62935
Description
This PR updates the wp-prettier dependency from version 2.6.2 to 3.0.3 and refines the ESLint ignore patterns for better build management. The changes aim to fix the issues with
lint:jsdoc
andlint:jsdoc:fix
scripts.Changes proposed in this Pull Request
build-module
andbuild-types
directories/build
withbuild
for consistency*.min.js
pattern to ignore minified filesTesting Instructions
npm install
to update dependenciesnpm run lint:jsdoc
to verify linting worksnpm run lint:jsdoc:fix
to verify auto-fixing worksScreenshots